r-lib / testthat

An R 📦 to make testing 😀
https://testthat.r-lib.org
Other
868 stars 313 forks source link

Use `R_NO_REMAP` #1929

Closed hadley closed 2 months ago

hadley commented 4 months ago

From BDR:

We are increasing the encouragement amongst C++ using packages to use R_NO_REMAP . Several fail because of

/Users/ripley/R/Library/testthat/include/testthat/testthat.h:175:10: error: use of undeclared identifier 'ScalarLogical'; did you mean 'Rf_ScalarLogical'? return ScalarLogical(success); ^~~~~ Rf_ScalarLogical

and there is another instance in that file.

Please use the safer form in your next update.

hadley commented 2 months ago

Now in #1952