search

r-lib / testthat

An R 📦 to make testing 😀
https://testthat.r-lib.org
Other
868 stars 313 forks source link

Snapshot failures shouldn't cause max failures cancellation? #1943

Open lionel- opened 3 months ago

lionel- commented 3 months ago

Currently, by default, if you have lots of snapshot failures you need multiple runs of test() to update them all because the test run gets cancelled after a certain number of failures.

I think it would make sense to treat snapshot failures specially so they don't contribute to the failures counter and never cause a cancellation?

hadley commented 2 months ago

Yeah, I think that makes sense.