Open tillea opened 4 months ago
Ping?
@tillea
Just for curiosity what are the changes between versions 3.2.1.1 and 3.2.1?
As I can't find ChangeLog or News file related I did a simple diff between versions:
diff -ruN 3.2.1/DESCRIPTION 3.2.1.1/DESCRIPTION
--- 3.2.1/DESCRIPTION 2023-12-02 11:50:05.000000000 +0000
+++ 3.2.1.1/DESCRIPTION 2024-04-14 04:25:11.000000000 +0100
@@ -1,6 +1,6 @@
Package: testthat
Title: Unit Testing for R
-Version: 3.2.1
+Version: 3.2.1.1
Authors@R: c(
person("Hadley", "Wickham", , "hadley@posit.co", role = c("aut", "cre")),
person("Posit Software, PBC", role = c("cph", "fnd")),
@@ -31,10 +31,10 @@
Encoding: UTF-8
RoxygenNote: 7.2.3
NeedsCompilation: yes
-Packaged: 2023-11-30 22:07:21 UTC; hadleywickham
+Packaged: 2024-04-14 03:24:27 UTC; ripley
Author: Hadley Wickham [aut, cre],
Posit Software, PBC [cph, fnd],
R Core team [ctb] (Implementation of utils::recover())
Maintainer: Hadley Wickham <hadley@posit.co>
Repository: CRAN
-Date/Publication: 2023-12-02 11:50:05 UTC
+Date/Publication: 2024-04-14 05:24:52
diff -ruN 3.2.1/MD5 3.2.1.1/MD5
--- 3.2.1/MD5 2023-12-02 11:50:05.000000000 +0000
+++ 3.2.1.1/MD5 2024-04-14 04:25:11.000000000 +0100
@@ -1,4 +1,4 @@
-7a02630a3e38f7521fb5c44a3f697a8a *DESCRIPTION
+7ad03c426643c38668b5fe0673a9a970 *DESCRIPTION
d0b909bd833cd58ea0430eda333b6447 *LICENSE
98b8d9fa7a3c0f90c19158aa47ec85f1 *NAMESPACE
b682a5016b2f64f2b8704f47aa54c3eb *NEWS.md
@@ -113,7 +113,7 @@
1ece0759f60e98193d53545648d19146 *inst/examples/test-failure.R
522cf134c79624117d579f2c4d18f42b *inst/examples/test-success.R
543392950ccc39ed50ebf26c75de0910 *inst/include/testthat.h
-5058228172d50a29a234414c78b25399 *inst/include/testthat/testthat.h
+05f098fedb1fe85ee85de806f711779f *inst/include/testthat/testthat.h
b5816f117a5460c67e3e08b1c23dacbc *inst/include/testthat/vendor/catch.h
f481e7613929d4968a4a4c73031f7967 *inst/resources/catch-routine-registration.R
f35a879e88834e75aee99fc9817547a0 *inst/resources/test-cpp.R
diff -ruN 3.2.1/inst/include/testthat/testthat.h 3.2.1.1/inst/include/testthat/testthat.h
--- 3.2.1/inst/include/testthat/testthat.h 2023-11-29 18:00:12.000000000 +0000
+++ 3.2.1.1/inst/include/testthat/testthat.h 2024-04-14 04:23:53.000000000 +0100
@@ -172,7 +172,7 @@
extern "C" SEXP run_testthat_tests(SEXP use_xml_sxp) {
bool use_xml = LOGICAL(use_xml_sxp)[0];
bool success = testthat::run_tests(use_xml);
- return ScalarLogical(success);
+ return Rf_ScalarLogical(success);
}
# endif // TESTTHAT_TEST_RUNNER
@@ -198,7 +198,7 @@
# include <R.h>
# include <Rinternals.h>
extern "C" SEXP run_testthat_tests() {
- return ScalarLogical(true);
+ return Rf_ScalarLogical(true);
}
# endif // TESTTHAT_TEST_RUNNER
And there is changes in testthat.h that maybe causing the error.
I have yet not updated FreeBSD port, but soon I will test it too and share results.
Thanks
@tillea
I found that commit at https://github.com/r-lib/testthat/commit/93b88dbda3dd048e74dd2bce4623c9436d2013ff I will test it today
Hi, I tried to upgrade the Debian packaged testthat from version 3.2.1 to 3.2.1.1. We are running a test script in our CI which boils down to
inside the source tree (and when doing so I get the very same result). The CI contains a full build log which results in
Please let me know if you need further information to track down the issue. In case you can't reproduce the issue the Debian Med team policy contains a hint to a docker file which could be useful to reproduce the problem on a Debian sid system. Kind regards, Andreas.