r-lib / testthat

An R 📦 to make testing 😀
https://testthat.r-lib.org
Other
868 stars 313 forks source link

Should there be the reject button in `snapshot_review()`? #1960

Open olivroy opened 1 month ago

olivroy commented 1 month ago

Currently, there is no way to exit the shiny app without pressing Escape?

https://github.com/r-lib/testthat/blob/f060ccec365e1343ae926c53c215a423b295d7a8/R/snapshot-manage.R#L60-L63

However, I see that some code was implemented?

https://github.com/r-lib/testthat/blob/f060ccec365e1343ae926c53c215a423b295d7a8/R/snapshot-manage.R#L77-L90