search

r-lib / testthat

An R 📦 to make testing 😀
https://testthat.r-lib.org
Other
891 stars 316 forks source link

Is "Skip" in the snapshot review app broken? #2025

Open jennybc opened 1 day ago

jennybc commented 1 day ago

I'm working on making links like testthat::snapshot_review() work in Positron's package development tasks, which run in a terminal. In the course of this effort, I've launched that Shiny app a lot and it sure feels like "Skip" just does nothing. Is it me? Or is it broken?

The toy package I made this recoding with is here: https://github.com/jennybc/clilinks

At the time of writing, it has exactly 1 snapshot test, which will always fail.

https://github.com/user-attachments/assets/2b764370-8d95-4074-8555-8b166038b703

jennybc commented 1 day ago

The recording is made in RStudio, but I see the same in Positron and if I pop it out into a browser.

jennybc commented 1 day ago

From a slack convo:

I think the problem might be that there’s only one failing test so there’s nothing to skip to

I've updated the package mentioned above to have more failing snapshot tests and it doesn't seem to change anything.