Closed cthombor closed 1 year ago
Thanks for the report! Can you please link to a package that reproduces the behavior you want to change, and also include the output of urlchecker::url_check()
on that package? Thanks!
I am closing this for lack of information. Please reopen with more info if you still have this issue. Thanks!
Please consider adjusting url_check()'s handling of \<DOI:...>, so that it accepts arbitrary strings in the suffix field, rather than throwing an "Invalid URI scheme" error when the suffix field contains a colon or seems bizarre in any other way.
Screenshot below:
At https://link.springer.com/article/10.1023/A:1005082925477, the publisher Springer asserts that the DOI of this article is "10.1023/A:1005082925477".
dx.doi.org has no trouble with this (rather bizarre looking) suffix, with https://dx.doi.org/10.1023/A:1005082925477 redirecting to the publisher's page.
As noted in section 2.2 of the DOI handbook:
<DOI:10.1023/A:1005082925477>
is not a workaround, giving the same error message.Springer could use arbitrary chars in the suffixes of the other DOIs in their domain. So I think there's little to be gained by adding special-case to handle a "Springer-style" colon in the suffix of a DOI; although I'd guess that some escaping will be necessary, given the DOI: syntax of the callout.
I'm guessing that a \<DOI:10.1023/A:1005082925477> callout in the @description field of a 'data.R' element is what caused 'devtools::check_win_release()' to throw a fatal error (with a not-very-helpful message, reproduced below) on a package that I'm currently attempting to submit to CRAN:
'devtools::check_rhub(platforms="windows-x86_64-devel")' on my minimal 'testdoit' package does not throw an HttpException, although I think MiKTeX might have thrown an exception:
My glance at your 'urlchecker' codebase suggests to me that 'url_check()' is relying on something in Pandoc to handle the callouts.
So... perhaps this issue should be "kicked upstairs" to the pandoc team? But ... that'd require an MRE, which would in turn require some knowledge of pandoc -- and I'm a complete duffer in that regard.
Please understand that I'm not much more than a duffer in R, as this is my first experience with trying to create a package in R for submission to CRAN. I did hack pretty extensively in S, in the early 1990s, when using it to interpret test results from a multistream PRNG package I had developed in C/C++... but R has moved a long way from that codebase. In very impressive ways!
I'd like to take this opportunity to thank you and all the other volunteers for your work over the decades. It's still a very quirky language IMHO; but its packages are in amazingly good nick, with analysis and presentation features far more advanced than what I remember of S in the 1990s!