r-lib / usethis

Set up commonly used 📦 components
https://usethis.r-lib.org/
Other
854 stars 283 forks source link

Should `use_logo()` call or suggest `pkgdown::build_favicons()`? #1995

Closed olivroy closed 3 months ago

olivroy commented 3 months ago

In the wild, I noted that many packages have a logo in their package, but it is not recognized by usethis/pkgdown because the file is not named man/figures/logo.png

Examples of PRs I opened in various repos to address this.

The idea is that one can never build_site() locally and still have a running website, as use_pkgdown_github_actions() does that. However, as of pkgdown 2.1, favicons will no longer be built on CI.

Update from https://github.com/r-lib/usethis/issues/844 + https://github.com/r-lib/pkgdown/pull/2563

olivroy commented 3 months ago

r-lib/pkgdown#2611 is a better solution!