r-lib / vdiffr

Visual regression testing and graphical diffing with testthat
https://vdiffr.r-lib.org
Other
180 stars 31 forks source link

Update the embedded svglite implementation #106

Closed thomasp85 closed 3 years ago

thomasp85 commented 3 years ago

This PR updates the embedded graphic device to be based off the latest svglite version. Major changes

There is practically no visual difference in the output, except for a point sizing bug that has been fixed and now show points and circles in the correct size (slightly smaller). The textual difference is of course stark

There are failing tests mainly because I don't know how to update the test setup

thomasp85 commented 3 years ago

The engine version are now written into the svgfile as a top level data attribute. It is accessible in javascript directly through the dataset map of the svg element, e.g. SVGElement.dataset.engineVersion

lionel- commented 3 years ago

Thanks!