search

r-lib / vdiffr

Visual regression testing and graphical diffing with testthat
https://vdiffr.r-lib.org
Other
180 stars 31 forks source link

expect_doppleganger throws warnings due to expect_snapshot_file deprecation of binary arg #110

Closed arnaud-feldmann closed 3 years ago

arnaud-feldmann commented 3 years ago

Hi @lionel- ,

Hope you're doing well,

As it is stated in my title, expect_doppleganger throws a warning because of the deprecation of binary arg of testthat::expect_snapshot_file.

As you've done both commits, it is likely that you're aware of the issue. Through, in your master branch of vdiffr, it seems like the binary arg of testthat::expect_snapshot_file is still called.

image

Keep up the good work !

lionel- commented 3 years ago

I forgot about that and the warning didn't surface in vdiffr tests :(

Thanks!