r-lib / vdiffr

Visual regression testing and graphical diffing with testthat
https://vdiffr.r-lib.org
Other
185 stars 31 forks source link

R version required in DESCRIPTION differs from version specified in expect-doppelganger.R #113

Open JSchoenbachler opened 3 years ago

JSchoenbachler commented 3 years ago

The R version required in the DESCRIPTION file is R 3.2.0 - https://github.com/r-lib/vdiffr/blob/fc03e91cccac04baa875063513b630d80c02e197/DESCRIPTION#L25 Meanwhile, the expect_doppleganger function skips test evaluation if it is on any version before R 4.1.0 - https://github.com/r-lib/vdiffr/blob/fc03e91cccac04baa875063513b630d80c02e197/R/expect-doppelganger.R#L171-L173

As I understand it, R 3.2.0 is fine to use for the write_svg function, but not for the actual expect_doppleganger function. This was confusing to me until I actually read the source code, since there isn't any mention of it on the documentation site (other than a small blurb in the changelog under the unreleased 0.4.0 version).

I think it would make it more clear if you either updated the DESCRIPTION R version requirement or added a blurb about the R version soft requirement to the documentation!