search

r-lidar / lidR

Airborne LiDAR data manipulation and visualisation for forestry application
https://CRAN.R-project.org/package=lidR
GNU General Public License v3.0
614 stars 134 forks source link

Use autoconf to generate Makevars at install time #787

Open quinn-r88 opened 2 weeks ago

quinn-r88 commented 2 weeks ago

This PR adds a new configure script to the package, which will generate Makevar files when the package is installed. The configure script is generated by GNU autoconf from configure.ac, and must be regenerated by the developer when configure.ac is modified.

This PR also adds a cleanup script, which R will use to remove the files that configure will generate.

Resolves #786

References:

Jean-Romain commented 1 week ago

The PR is failing on windows. I know the error, I got it in another package and I remember I had a lot of trouble figuring out how to fix it. Sadly I do not remember the procedure.

quinn-r88 commented 1 day ago

hmmmmm. I don't have super convenient access to a windows cpu to debug this. How can I find the logs for these runs?

Jean-Romain commented 1 day ago

Me neither

https://github.com/r-lidar/lidR/actions/runs/11802549228/job/33612239436?pr=787

Jean-Romain commented 1 day ago

The solution is there, I remember:

https://github.com/R-ArcGIS/arcgisutils/commit/17b2520607370ab980d3d108a50e85ff59cf0fb6#diff-618cd5b83d62060ba3d027e314a21ceaf75d36067ff820db126642944145393eR4