r-lidar / rlas

R package to read and write las and laz files used to store LiDAR data
https://cran.r-project.org/package=rlas
GNU General Public License v3.0
34 stars 14 forks source link

Switch to C++14 under Boost 1.75.0 #49

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

As mentioned in issue 76 at the BH repo, its new version requires a switch of rlas to C++14 and will no longer compile with C++11. I have checked that this works, and can confirm that C++14 is allowed at CRAN. I have not checked if the switch to C++14 causes and issue under the current BH package (using Boost 1.72.0).

It would be great if you could consider upgrading to C++14 and upload an updated package, likely only once CRAN reopens in January, A simple patch is included below.

Please reach out if you have any questions, and a big Thank You! for maintaining rlas on CRAN.

diff -ru rlas.orig/src/Makevars rlas/src/Makevars
--- rlas.orig/src/Makevars      2019-09-06 12:09:32.000000000 +0200
+++ rlas/src/Makevars   2020-12-12 22:59:03.333898341 +0100
@@ -59,4 +59,4 @@
 TEMP1   =  $(SOURCES:.cpp=.o)
 OBJECTS =  $(TEMP1:.c=.o)

-CXX_STD = CXX11
+CXX_STD = CXX14
Only in rlas/src: Makevars~
diff -ru rlas.orig/src/Makevars.win rlas/src/Makevars.win
--- rlas.orig/src/Makevars.win  2019-04-26 15:15:49.000000000 +0200
+++ rlas/src/Makevars.win       2020-12-13 15:37:38.045303228 +0100
@@ -59,4 +59,4 @@
 TEMP1   =  $(SOURCES:.cpp=.o)
 OBJECTS =  $(TEMP1:.c=.o)

-CXX_STD = CXX11
+CXX_STD = CXX14