search

r-lyeh-archived / bundle

:package: Bundle, an embeddable compression library: DEFLATE, LZMA, LZIP, BZIP2, ZPAQ, LZ4, ZSTD, BROTLI, BSC, CSC, BCM, MCM, ZMOLLY, ZLING, TANGELO, SHRINKER, CRUSH, LZJB and SHOCO streams in a ZIP file (C++03)(C++11)
zlib License
610 stars 86 forks source link

Compiler warnings #9

Closed eXpl0it3r closed 9 years ago

eXpl0it3r commented 9 years ago

When compiling bundle (with GCC) you'll get a lot of warnings. I simply wanted to know if you'd like to reduce these or just keep the "embedded" external library sources exactly the same?

r-lyeh-archived commented 9 years ago

Hard to say as this is one of the compromises I make when amalgamating other sources. I would like to remove the warnings eventually but I do not want to be sync'ing all my changes with every external update either. I might try to remove warnings on older (more stable) libraries though (which are not going likely to change any further).

eXpl0it3r commented 9 years ago

Okay, yeah it's a minor annoyance, especially if the warnings originate from for loops which use int instead of std::size_t or similar...

Otherwise, I really like the simplicity of things. In my opinion compression libraries design their APIs often way too complicated.

Feel free to close this issue. :wink:

r-lyeh-archived commented 9 years ago

it's only a problem for the guys that compile warnings as errors. and they're quite a few. I will try to remove as many warnings as possible. thx for the feedback :)