search

r-multiverse / help

Discussions, issues, and feedback for R-multiverse
https://r-multiverse.org
MIT License
2 stars 2 forks source link

Extra assertions on URLs #11

Closed wlandau closed 4 months ago

wlandau commented 4 months ago

I want to keep r.releases.utils:::assert_package_lite() the way it is, but r.releases.utils:::assert_package() might need more assertions. One that we are currently missing is to check if the URL is actually online. Anything else we are missing?

shikokuchuo commented 4 months ago

There is already a PR for this https://github.com/r-releases/r.releases.utils/pull/5

wlandau commented 4 months ago

Thanks @shikokuchuo! Much appreciated! I created a new release with your contribution.

One might also consider checking that a release exists, but I do not think it is necessary.

shikokuchuo commented 4 months ago

To check that we'd probably need to interface with the APIs, and then it's a case of URL manipulation and a lot of extra work for not very much gain.

Did you have anything else to add to this issue?

wlandau commented 4 months ago

I can't think of anything else. We might have to do more if https://github.com/r-releases/help/issues/13#issuecomment-1975153905 fails, but according to Jeroen it should succeed.

wlandau commented 4 months ago

With #13 solved, I think we can close this one for now.

wlandau commented 3 months ago

Hmm... I tried creating a test universe with a released repo that is not an R package, and I saw: https://github.com/r-universe/wlandau-test/actions/runs/8139061504/job/22241346983#step:3:61. I am not sure it is feasible to check for a DESCRIPTION file, and I think non-R-package registrations will not be as common, but it is worth pointing out.

wlandau commented 3 months ago

Regardless, I still like how we handled #13.