search

r-multiverse / help

Discussions, issues, and feedback for R-multiverse
https://r-multiverse.org
MIT License
2 stars 2 forks source link

Merging PRs requiring manual review #30

Closed shikokuchuo closed 3 months ago

shikokuchuo commented 3 months ago

I thought these should merge if I took off the 'manual review' label.

I'm sure some did when I added some packages yesterday, but this one and a couple more the same failed just now:

https://github.com/r-releases/r-releases/pull/92#issuecomment-1981959516

Failed as in got re-tagged for manual review.

wlandau commented 3 months ago

That one was flagged because it it comes from https://github.com/cran. Since our goal is to become independent from CRAN eventually, I recall we had decided to not automatically merge those.

shikokuchuo commented 3 months ago

Yes I don't have an issue with that, it's the fact that it was flagged twice. You can see from the PR. Am I supposed to just merge it as opposed to remove the 'manual-review' label?

wlandau commented 3 months ago

Yeah, merging is fine.

The bot uses the manual-review label to decide whether it should scan the PR from scratch. If you remove the label, it processes it again as it if were the first time. The alternative is to scrape comments, which would not be reliable.

shikokuchuo commented 3 months ago

Ok, thanks for confirming. So for example some temporary internet access error, the tag can be removed and it will process it again.

wlandau commented 3 months ago

Exactly. That will work if there was a network error trying to merge, for example.