search

r-neal-kelly / the_scriptures

A Scriptural Study Suite
https://r-neal-kelly.github.io/the_scriptures/
Other
0 stars 0 forks source link

Layout Problems After Resize #4

Closed r-neal-kelly closed 8 months ago

r-neal-kelly commented 9 months ago

Sometimes after a browser resize, typically when maximizing or when a lot of execution is occurring, the layout windows are not correctly scrolled. This could be because of an event not firing in the right order, or it could be because we are relying too much on the css to do the job for us.

One solution is of course to enforce the scroll after a resize event, however it may be better to simply hide windows that can't currently be seen, which is computationally more friendly for the browser anyway. So that's probably the correct fix for this problem.

r-neal-kelly commented 9 months ago

This is related to the need of improving the view entity such that it can handle resize events. unlike its other method events, the resize event should probably always call the resize function so that not every entity has to define it for its children? and we could just pass the basic width and height of the parent element to the children.