r-park / todo-react-redux

Todo app with Create-React-App • React-Redux • Firebase • OAuth
https://todo-react-redux.firebaseapp.com
MIT License
1.02k stars 272 forks source link

Firebase Deployment #68

Closed KillerBee05 closed 7 years ago

KillerBee05 commented 7 years ago

Within the firebase.json. The public is set to "target". When I deploy it doesn't appear to find this path or directory. This is a recent issue. I've deployed fine before. Now all of the sudden it can't find the directory or path. Are you still able to deploy or are you having this issue ?

KillerBee05 commented 7 years ago

Also npm run build fails even when I started from scratch. Npm start works as well as firebase serve.

r-park commented 7 years ago

Hi @KillerBee05 – I was able to clone, build, and deploy. What kind of errors are you seeing?

KillerBee05 commented 7 years ago

Thank you for taking your time to check. Within the Command Prompt I get cannot find public directory. So it can't find the specified "target" within the firebase.json. I change 'target' to 'src' and it deploys just fine, just can't see anything on the page. I change it back to target and I get this error. I tried cloning your repo and starting over, and I ran into the same issue. I updated my firebase tools recently. Im not sure if thats the issue though.

image

KillerBee05 commented 7 years ago

image

r-park commented 7 years ago

You mentioned that the build was failing as well — what errors are you seeing?

target directory is created by npm run build, so if the build is failing then the directory and build artifacts are probably not being generated.

KillerBee05 commented 7 years ago

Oh okay. This is what im getting when I run the build. image

r-park commented 7 years ago

Looks like eslint may have found some errors. Try running npm run lint and see if there are any problems reported by eslint.

An error would look something like this:

$ npm run lint

> todo-react-redux@0.6.0 lint /Users/rpark/todo-react-redux
> eslint -c .eslintrc.yml *.js src server

/Users/rpark/todo-react-redux/karma.conf.js
  19:5  error  Parsing error: Unexpected token, expected ,

✖ 1 problem (1 error, 0 warnings)
KillerBee05 commented 7 years ago

Yeah that was it, holy cow that was a pain to clear out some of these errors.

image

I ended up having to comment these lines out cause I don't know what it wants. I've tried everything to get them to go away. Any pointers to get it Lint to be satisfied?

image

r-park commented 7 years ago

Have a look at this: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md

KillerBee05 commented 7 years ago

Word, thanks for the help.