Using docker provider for molecule testing results in indefinite hang on pihole installation.

[r-pufky]

Pulling this issue out into a separate bug. See links for additional context.

Using docker for testing in molecule results in the pihole installer indefinitely hanging, during DNS service restart using systemd.

This tracks the resolution of this issue and is a blocker for the next release.

added the molecule github workflow with above images for testing. still failing at pihole install and not seeing clear error message https://github.com/juju4/ansible_pihole/actions/runs/6207856797/job/16853461529#step:7:353

See: https://github.com/r-pufky/ansible_pihole/pull/21#issuecomment-1716822044

Disabling systemd-resolved DNSStubListener and restarting systemd-resolved

It is hanging on restarting systemd-resolved and returning an exit code of 1. This is the docker/systemd interaction I mentioned above. Succeeds in a full VM -- I've been poking around on it on my side working backwards from vagrant/libvirt.

Let's bug this and assign yourself to it so we can get the base framework in to work with; we can discuss more about fixing in that bug.

on dependencies, imho role should include whatever is needed to be played. base docker image allow testing with minimal image vs lxd or github images which are more full systems and somewhat silent dependencies like git or some ansible modules-related python packages.

The role was always intended to be run on baremetal or a VM, not in a docker container. I'm not against adding those silent dependencies, but please either add a comment above that block or another list (and include in the install tasks) that clearly delineates what/why those packages are for (e.g. molecule testing on docker). This also helps when checking deps for major version upgrades.

_Originally posted by @r-pufky in https://github.com/r-pufky/ansible_pihole/issues/21#issuecomment-1724282462_

[r-pufky]

Initial testing framework has been committed to mainline; @juju4.

[juju4]

Thanks a lot @r-pufky !