search

r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
175 stars 28 forks source link

New str() methods #228

Closed lewinfox closed 4 years ago

lewinfox commented 4 years ago

Fixes #227: as discussed, new str methods for units and mixed_units classes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #228 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   94.05%   94.09%   +0.03%     
==========================================
  Files          18       18              
  Lines         892      897       +5     
==========================================
+ Hits          839      844       +5     
  Misses         53       53
Impacted Files Coverage Δ
R/mixed.R 97.91% <100%> (+0.13%) :arrow_up:
R/misc.R 96.55% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c21aef...1073bd1. Read the comment docs.

lewinfox commented 4 years ago

Apologies for the delay coming back to you - looks great from my end! Your implementation is much nicer. I'm very happy with the way it all looks and it will make my project much easier to debug.

I apologise for wasting your time with NextMethod.

Not at all - it was a good learning opportunity for me :+1: I'm delighted to have been able to contribute. Thanks for your help and patience!