search

r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
175 stars 28 forks source link

Remove use of isFALSE to allow use of R < 3.5 #230

Closed langmm closed 4 years ago

langmm commented 4 years ago

Closes #229

codecov[bot] commented 4 years ago

Codecov Report

Merging #230 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   94.09%   94.09%   +<.01%     
==========================================
  Files          18       18              
  Lines         897      898       +1     
==========================================
+ Hits          844      845       +1     
  Misses         53       53
Impacted Files Coverage Δ
R/symbolic_units.R 98.8% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1e01bc...c5adbd8. Read the comment docs.

Enchufa2 commented 4 years ago

I think it's more safe and clear if we just port the function and keep the syntax. Also, I've bumped the version and updated the NEWS. Many thanks!