r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
175 stars 28 forks source link

Fix printing of empty mixed_units #256

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

Subsetting worked ok. It was the print and str methods which were buggy for the cases described in #248.

codecov[bot] commented 3 years ago

Codecov Report

Merging #256 (2ec8559) into master (cc1911f) will decrease coverage by 0.10%. The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   94.20%   94.09%   -0.11%     
==========================================
  Files          19       19              
  Lines         914      914              
==========================================
- Hits          861      860       -1     
- Misses         53       54       +1     
Impacted Files Coverage Δ
R/mixed.R 97.67% <90.00%> (-2.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc1911f...2ec8559. Read the comment docs.

Enchufa2 commented 3 years ago

Also, I found that the c.mixed_units method was defined but not exported. Fixed here too.

Enchufa2 commented 3 years ago

@edzer Kind reminder.