r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
175 stars 28 forks source link

remove deprecations, bump minor version #259

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

This removes as.units, as_cf, make_unit and parse_unit, which have been deprecated for a long time (since v0.5, 2018-01-07), and consequently bumps version to 0.7-0. I removed all calls and mentions to them in docs, demos and tests.

I think it's time to remove ud_units too, which is unneeded and soft-deprecated since v0.5 as well (and it only generates confusion, e.g. #211), but I wanted to ask you @edzer first.

codecov[bot] commented 3 years ago

Codecov Report

Merging #259 (14b3549) into master (541a96c) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   93.97%   94.05%   +0.07%     
==========================================
  Files          19       18       -1     
  Lines         897      891       -6     
==========================================
- Hits          843      838       -5     
+ Misses         54       53       -1     
Impacted Files Coverage Δ
R/misc.R 100.00% <ø> (ø)
R/conversion.R 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 541a96c...14b3549. Read the comment docs.

edzer commented 3 years ago

Good idea. What was again the reason to deprecate ud_units, do we no longer use it? I mention it in the vignette, that would need updating too.

Enchufa2 commented 3 years ago

Prior to v0.5-0, ud_units was internally used by set_units and as_units. NEWS for v0.5-0 said:

ud_units is no longer necessary and is soft-deprecated, and may be removed in a future release.

edzer commented 3 years ago

OK, let's pull the plug. I'll update that vignette.

Enchufa2 commented 3 years ago

Ok, plug pulled in the commit referenced above. I've removed:

I've converted every appearance of with(ud_units, someunit) to make_units(someunit).

edzer commented 3 years ago

Great!