krlmlr commented 3 years ago

This gives underlines for every other block of three digits, and all the other details of default pillar formatting.

Working on making formatting customizable, see https://pillar.r-lib.org/dev/articles/numbers.html for a primer. When merged, units will also benefit.

CC @lionel-.

Includes part of #274.

codecov[bot] commented 3 years ago

Codecov Report

Merging #273 (7ac8a80) into master (3e451b3) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   94.29%   94.40%   +0.10%     
==========================================
  Files          18       18              
  Lines         877      876       -1     
==========================================
  Hits          827      827              
+ Misses         50       49       -1

Impacted Files	Coverage Δ
R/conversion.R	`88.23% <ø> (ø)`
R/tidyverse.R	`96.42% <100.00%> (+3.32%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e451b3...ec8ff07. Read the comment docs.

Enchufa2 commented 3 years ago

LGTM. Thanks!

r-quantities / units

Use default pillar_shaft() method for numbers #273

Codecov Report