search

r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
173 stars 27 forks source link

units breaks on r-devel-windows-x86_64-gcc10-UCRT #278

Closed edzer closed 3 years ago

edzer commented 3 years ago

See https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64-gcc10-UCRT/units-00install.html

It looks like this is the same problem as https://github.com/r-spatial/sf/issues/1629

It looks like @kalibera already addressed this, in https://svn.r-project.org/R-dev-web/trunk/WindowsBuilds/winutf8/ucrt3/r_packages/patches/CRAN/units.diff

in which case the problem should resolve after rebuild in 24 hrs or so.

kalibera commented 3 years ago

Yes, the latest version already passes locally on my system.

Enchufa2 commented 3 years ago

I suppose that we just need to add this Makevars.ucrt file, right? Will this patch be temporarily applied on CRAN until our next submission, or are we required to send a patch release ASAP?

kalibera commented 3 years ago

It is not urgent, if you integrate the patch (the Makevars.ucrt) into your next submission, that'd be fine. If you could then also check that there are no other issues with the package with the new toolchain, that'd be great.