search

r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
173 stars 27 forks source link

Keep pillar attribute in vec_restore() #280

Closed krlmlr closed 3 years ago

krlmlr commented 3 years ago

Required for vec_slice(). Follow-up to #275.

codecov[bot] commented 3 years ago

Codecov Report

Merging #280 (541d2d1) into master (e215530) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 541d2d1 differs from pull request most recent head e0b7058. Consider uploading reports for the commit e0b7058 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          18       18           
  Lines         877      877           
=======================================
  Hits          828      828           
  Misses         49       49
Impacted Files Coverage Δ
R/make_units.R 89.83% <ø> (-0.26%) :arrow_down:
R/tidyverse.R 96.77% <100.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e215530...e0b7058. Read the comment docs.

krlmlr commented 3 years ago

macOS devel doesn't have binaries for udunits2, otherwise builds look good.

krlmlr commented 3 years ago

See https://pillar.r-lib.org/dev/articles/numbers.html#units for a demo, I quite like it! We can set display options on a units object, it survives arithmetics.

Enchufa2 commented 3 years ago

Could you please rebase/merge current master? I've added a workflow to check quantities on PR.

Enchufa2 commented 3 years ago

All good, thanks!