search

r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
173 stars 27 forks source link

Release units 0.8-0 #295

Closed Enchufa2 closed 2 years ago

Enchufa2 commented 2 years ago

Time for a new release! :) I've run a complete revdep check, and we have 9 issues.

Enchufa2 commented 2 years ago

All issues notified. There are basically two kinds of issues: 1) references to the old interface to install units, and 2) an incorrect usage of all.equal, which, due to a bug in our side, wasn't triggering errors previously, and now it is corrected.

I suggest waiting for a month or so before releasing the new version.

edzer commented 2 years ago

Great work - sounds good!!

hongyuanjia commented 2 years ago

@Enchufa2 Thanks for the issue. I think I already change the code some time ago in order to keep it compatible with units >= 0.7, See https://github.com/hongyuanjia/eplusr/blob/master/R/units.R#L8-L20. Do you have any insights why this did not work? Thanks.

Enchufa2 commented 2 years ago

@hongyuanjia Once units 0.8.0 is uploaded with these functions removed, you package will give a WARNING due to references to missing functions. It is true that your code would never call them (because it checks units version first), but anyway the WARNING will pop up, because CRAN checks for this are not this clever. Therefore, as I said in the comment I left in your repo, you either remove those calls completely and enforce units >= 0.7.0 in your DESCRIPTION file, or implement the trick I use in the constants package.

hongyuanjia commented 2 years ago

Thanks for the trick of getExportedValue(). This PR (https://github.com/hongyuanjia/eplusr/pull/500) should fix it.

Enchufa2 commented 2 years ago

@edzer A month has passed. I've repeated the revdep check and we are good to go (no new issues; some of the ones above are already solved, some of them are already on CRAN). Time for a new release?

Enchufa2 commented 2 years ago

Oh, there's some issue with pillar now in the latest commit? Let me check.

Enchufa2 commented 2 years ago

It seems that pillar v1.7.0 produces an output with one space less. Solved in https://github.com/r-quantities/units/commit/ccf9bfedb419ea2f3d673f4681fd11c966d4b5fd.

BTW, we have a NOTE on CRAN now saying that udunits2 is suggested but it's orphaned. Time to remove it from Suggests?

edzer commented 2 years ago

Yes, time to remove udunits2...

Enchufa2 commented 2 years ago

All set in 0b166d9e4fe870af838680c5e2c755839a2bba3f. We're good to go.

edzer commented 2 years ago

Thanks; will now submit sf, then units.

edzer commented 2 years ago

now on CRAN.

Enchufa2 commented 2 years ago

Excellent, thanks!