Closed billdenney closed 1 year ago
Base: 91.55% // Head: 91.54% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
ead4493
) compared to base (cc947e2
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Good catch! Thanks for looking into this. Then let's try to just preserve those names in ud_convert()
. Please, try the commit above.
Since it passes the added test, it works as desired (and better than my fix since it works at the source).
Fix #305
Now, names are preserved with unit conversion. The underlying issue is that the C-connection function
ud_convert
drops the names. I don't know how to fix that, and it seems to be used only at the location that I found in the code.