r-quantities / units

Measurement units for R
https://r-quantities.github.io/units
172 stars 27 forks source link

remove tolerance from comparisons with logical operators #353

Closed Enchufa2 closed 11 months ago

Enchufa2 commented 11 months ago

Closes #351

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (96cf9a1) 91.48% compared to head (9d3c636) 91.48%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #353 +/- ## ======================================= Coverage 91.48% 91.48% ======================================= Files 19 19 Lines 998 998 ======================================= Hits 913 913 Misses 85 85 ``` | [Files Changed](https://app.codecov.io/gh/r-quantities/units/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=r-quantities) | Coverage Δ | | |---|---|---| | [src/udunits.cpp](https://app.codecov.io/gh/r-quantities/units/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=r-quantities#diff-c3JjL3VkdW5pdHMuY3Bw) | `87.87% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Enchufa2 commented 11 months ago

@edzer I think we should make a new patch release for this one.

edzer commented 11 months ago

Great work!

I think we should make a new patch release for this one.

I Agree!

Enchufa2 commented 11 months ago

Great, please let me know if there's any issue with the submission.