search

r-raymond / nixos-mailserver

A complete and Simple Nixos Mailserver
GNU General Public License v3.0
181 stars 27 forks source link

My changes #126

Open griff opened 6 years ago

griff commented 6 years ago

Here are the changes discussed in #61

Right now it downloads the ClamAV DB from my domain files.griff.name

r-raymond commented 6 years ago

Awesome! Give me some time to look through it. Any additional pair of eyes is very welcome!

griff commented 6 years ago

Have you considered disabling Travis CI cache so that CI works again? I also believe both Travis and hydra.nixos.org store their cache/files in S3 so caching /nix/store will only be faster for things not built by hydra.nixos.org which this project doesn't have that much of.

r-raymond commented 6 years ago

@griff Seems you are right. Thanks for the insight :) - Also I think I don't have any complaints about your PR, thanks for the great work!

sorki commented 6 years ago

Testing with master pulled few minutes ago and everything passes (deployment to libvirt and both tests).

eqyiel commented 6 years ago

@griff just in case you haven't got notifications set up for GitLab, we are discussing this in https://gitlab.com/simple-nixos-mailserver/nixos-mailserver/merge_requests/126. Thanks for your contribution!