search

r-raymond / nixos-mailserver

A complete and Simple Nixos Mailserver
GNU General Public License v3.0
181 stars 27 forks source link

Add ManageSieve support #54

Closed erosennin closed 6 years ago

erosennin commented 6 years ago

Fixes #53.

r-raymond commented 6 years ago

Awesome, I can't find any more problems. Thanks for the changes!

Did you test if using managesieve works? I have no idea how to write an integration test for that :)

@eqyiel: in the newest version, the usernames are not real accounts anymore. Is it save to set vmail as the owner of the scripts?

erosennin commented 6 years ago

Works for me in KMail and in Thunderbird with the Sieve plugin.

We could use some console client for testing, like sieve-connect, but it's not in Nix packages and packaging it seems a bit too much of a pain right now. :)

eqyiel commented 6 years ago

@r-raymond are you talking about this commit? https://github.com/r-raymond/nixos-mailserver/commit/2d0648e0f4c57e8a57ad34bbd8ea514fcf18c543

IIRC, in this case the owner of the scripts has to be vmail otherwise the virtual users won't be able to modify them.

@erosennin I'm using this right now and it seems fine to me, thanks for looking into it!

r-raymond commented 6 years ago

Yes, that is the commit I'm worried about. Shouldn't that break

chown "${name}:${vmailGroupName}" "/var/sieve/${name}"

?

eqyiel commented 6 years ago

@r-raymond I see what you mean - in that case this should be changed to chown "${vmailUserName}:${vmailGroupName}" "/var/sieve/${name}" in 2.1, AFAICT it will be sufficient for dovecot to have write permissions to the file after the switch to passwd-file users (but I'll check it out if you want to rebase that onto master after this lands) 👍

r-raymond commented 6 years ago

@eqyiel Ok, then I'll merge this but I'll fix the chowns before I'll post a new release.

Thanks everyone!