Closed r-scheele closed 2 years ago
@r-scheele I'm wondering why we are reinventing the wheel to authenticate with the OIDC protocol. Are we sure we need all that boilerplate of code? Isn't there any reusable package out there in the fastapi ecosystem? @Youngestdev thoughts about this?
Also, we are using requests
that is blocking the event loop and still using json.dumps
while I guess we can coherently only rely on pydantic
.
@r-scheele I'm wondering why we are reinventing the wheel to authenticate with the OIDC protocol. Are we sure we need all that boilerplate of code? Isn't there any reusable package out there in the fastapi ecosystem? @Youngestdev thoughts about this?
Also, we are using
requests
that is blocking the event loop and still usingjson.dumps
while I guess we can coherently only rely onpydantic
.
Unfortunately, there's no reusable package for GitHub authentication yet. This might be a good time to build a mini one so we can just integrate. We're only using GitHub for authentication atm.
I'll work on a small package to help with our situation so we can reduce the amount of code we're using. What do you think, @francbartoli ?
Re: the requests
, I'll take a look at it 🤔.
Login: