r-spark / sparknlp

Other
31 stars 6 forks source link

nlp_text_matcher does not use "options" argument #1

Closed dkincaid closed 4 years ago

dkincaid commented 4 years ago

Due to a problem calling methods that require a Scala Map type as a argument (see https://github.com/rstudio/sparklyr/issues/1058) the nlp_text_matcher options argument is currently not used.

dkincaid commented 4 years ago

A fix for this is currently undergoing review. I verified that the change works in this case and modified text-matcher.R accordingly. Currently the fix is only in the kevinykuo/sparklyr@feature/map-serialize. The pull request is https://github.com/rstudio/sparklyr/pull/2155

dkincaid commented 4 years ago

Fixed in sparklyr 1.0.4.9002