search

r-spatial / RQGIS3

GNU Lesser General Public License v3.0
69 stars 19 forks source link

Update macOS compatibility #16

Closed pat-s closed 4 years ago

pat-s commented 4 years ago

I was not able to get RQGIS3 working with the official QGIS installer. See https://gis.stackexchange.com/questions/333540/loading-pyqt5-modules-from-qgis3-pyqgis for the blocking issue.

Therefore I decided that we do not support it for now. We stop early if no homebrew installation is found. This requirement is now also reflected in the vignette.

In addition I tidied the code and removed some lines setting certain env values which are apparently not required to run successfully.

I've added argument homebrew to set_env() to let users decide which installation they want to use (even thought we only support homebrew for now). This may seem unnecessary for the user at first but I need this internally to conditionally set things depending on the QGIS installation way.

Other changes

pat-s commented 4 years ago

For both macOS and Linux test are failing on Travis but the R CMD check is running at least. Merging now :)