Add logLik method (Fix #6)

r-spatial / classInt

Choose Univariate Class Intervals

https://r-spatial.github.io/classInt/

33 stars 8 forks source link

Add logLik method (Fix #6) #11

Closed billdenney closed 5 years ago

billdenney commented 5 years ago

Fix #6

rsbivand commented 5 years ago

No roxygen at all permitted. You must produce a proper *.Rd file yourself, I never write roxygen as it invites laziness. Please also provide full tests (not testthat) for edge cases (you may do this in a complete and proper set of examples, one of the roxygen traps is inviting unhelpful examples without references to articles etc. that they reproduce). I still do not see any motivation for this, no cartographer using the package needs this.

billdenney commented 5 years ago

I think that I misunderstood your response in #6. As I am not a cartographer, I don’t know that literature. The function would be useful in my field of pharmacometrics, but I will close this and the original issue as I cannot find cartography-specific motivations.