search

r-spatial / classInt

Choose Univariate Class Intervals
https://r-spatial.github.io/classInt/
33 stars 8 forks source link

Add "headtails" #20 #24

Closed dieghernan closed 4 years ago

dieghernan commented 4 years ago

Good morning:

This PR adds the "headtails" method to classIntervals (#20 ). I included some examples on man, see how the example renders here: https://rpubs.com/dieghernan/classIntervals

A change has been made over the standalone function: now breaks initalises with min(var, na.rm = TRUE) instead of NULL. Doing this, the breaks vector inherits units if applicable, and "headtails" works well when units are passed (this can be seen on the examples).

A vignette is coming on the next weeks, I would use this as starting point: https://r-spatial.github.io/spdep/articles/CO69.html

As an additional question, would you consider including myself as a ctb of the package?

rsbivand commented 4 years ago

Thanks; please check that your entry in DESCRIPTION is accurate, maybe a better email? Do you have an ORCiD, if so, maybe add?

dieghernan commented 4 years ago

I added #25 , thanks