search

r-spatial / dtwSat

Time-Weighted Dynamic Time Warping for satellite image time series analysis
https://www.victor-maus.com/dtwSat/
GNU General Public License v3.0
131 stars 39 forks source link

Address #38 and #42 #44

Closed nk027 closed 3 years ago

nk027 commented 5 years ago

This should address problems uncovered in #42 and add verbosity and provide a base for fixing #38. Regarding the latter see the commit message for options to proceed:

While twdtwTimeSeries takes in vectors (in addition to 2-dimensional objects) this may lead to problems further down the line - e.g. in twdtwApply (see Issue #38). This could also be adressed by: a) Throwing an error (in case vectors should never be provided) b) Converting to 2-dimensions (e.g. by calling resampleTimeSeries) c) Fix issues stemming from the vector (i.e. in twdtwApply)

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage    0.74%   0.74%   -0.01%     
=========================================
  Files          44      44              
  Lines        2021    2026       +5     
=========================================
  Hits           15      15              
- Misses       2006    2011       +5
Impacted Files Coverage Δ
R/twdtwAssess.R 0% <0%> (ø) :arrow_up:
R/class-twdtwTimeSeries.R 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33d2940...249cf74. Read the comment docs.