search

r-spatial / dtwSat

Time-Weighted Dynamic Time Warping for satellite image time series analysis
https://www.victor-maus.com/dtwSat/
GNU General Public License v3.0
130 stars 39 forks source link

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #56

Closed rsbivand closed 1 year ago

rsbivand commented 1 year ago

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.

rsbivand commented 1 year ago

This package has strong dependence on at least one of rgdal, rgeos or maptools, but does not seem to use any functionality in code. The usage may have been in raster, which now uses terra instead, or may be in examples or vignettes. Please move all use of rgdal, rgeos or maptools to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See https://r-spatial.org/r/2022/12/14/evolution2.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1.

rsbivand commented 1 year ago

Please also see https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023.

vwmaus commented 1 year ago

@rsbivand thank you for the reminder. Working on a fix for this is scheduled to start in mid-June.

rsbivand commented 1 year ago

@vwmaus @appelmar @nk027 Only three months remain before retiring packages are archived. I don't see any movement in this repo. Untried - drop rgdal completely and add sf as Suggests:. Then run check as suggested in https://r-spatial.org/r/2023/05/15/evolution4.html (current sp (status 2), no retiring packages on library path).

vwmaus commented 1 year ago

@rsbivand I started working on this.

vwmaus commented 1 year ago

dtwSat 1.0.0 removes all obsolete dependencies.