search

r-spatial / leafem

leaflet extensions for mapview
https://r-spatial.github.io/leafem/
Other
108 stars 30 forks source link

`extendLayerControl` should be `extendLayersControl` + some modifications #98

Open tim-salabim opened 5 days ago

tim-salabim commented 5 days ago

@trafficonese I renamed extendLayerControl() to extendLayersControl() (mind the 's') to be in line with the original leaflet::addLayersControl(). I also adjusted a few things regarding CSS and default icons. Among other things, I added package {fontawesome} to Suggests, because I like those icons much better than the emojis.

All in all it now looks like this: image

I am still not sure whether this is the end of what I have in mind, but I wanted to let you in on these changes as early as possible, given that you did all the work on this so far.

I hope that is OK with you. https://github.com/r-spatial/leafem/commit/18b80d601e5695207e484387b239338d7c23a2e4

trafficonese commented 3 days ago

looks great to me :)

tim-salabim commented 3 days ago

There's still a few things I nee to iron out, but I am quite happy with this myself! Thanks again for all the great work!!