findGRASS()'s default searchLocation in Linux takes long to find grass

r-spatial / link2GI

Simplify the linking of GIS/RS and CLI tools

https://r-spatial.github.io/link2GI

GNU General Public License v3.0

25 stars 7 forks source link

findGRASS()'s default searchLocation in Linux takes long to find grass #46

Closed florisvdh closed 3 years ago

florisvdh commented 4 years ago

Internally, findGRASS() does this in non-Windows systems:

if (searchLocation=="default") searchLocation <- "/usr"

I suggest to set the default to "/usr/bin". It works much faster. Are there cases where grass is installed in another folder than /usr/bin, when installed under /usr?

gisma commented 3 years ago

sorry have been for personal reasons a fairly long time off. well probably only if one compile grass from scratch. in this case the user obviouslyknow how to adress this path.

gisma commented 3 years ago

have accepted the pull request Thanks for contributing.

florisvdh commented 3 years ago

I think there may have been some confusion while accepting PR #45 + closing this issue. PR #45 solved #44 but not the suggestion made here. From your response, it seems you would welcome the idea. So I've made another PR #47 that tries to implement the request made here.