st_make_valid removed from lwgeom (moved to sf)

edzer commented 4 years ago

This affects the following revdeps, who have been informed:

jlacko commented 4 years ago

I have a question related to this: is there a consensus approach to handling the transition?

When I use sf::st_make_valid instead of lwgeom::st_make_valid in my package I get an error in some evironments (e.g. Travis) that lwgeom is not available. Apparently sf uses it as a fallback in case of old GEOS; the version on Travis is rather ancient - but Travis is a key tool in CI.

Loading required package: sf
Linking to GEOS 3.7.1, GDAL 2.2.2, PROJ 4.9.2
── 1. Error: (unknown) (@test-2-code.R#20)  ────────────────────────────────────
lwgeom required: install that first

edzer commented 4 years ago

Yes, that is right, and that will remain the case until the GEOS version having st_make_valid has propagated through all distributions. For such cases you can still change the import, but keep lwgeom in Suggests:.

jlacko commented 4 years ago

thank you, suggests: lwgeom has to remain; then all is well...

r-spatial / lwgeom

st_make_valid removed from lwgeom (moved to sf) #52