search

r-spatial / lwgeom

bindings to the liblwgeom library
https://r-spatial.github.io/lwgeom/
58 stars 23 forks source link

Add SQLITE in the SystemRequirements line of the DESCRIPTION file #73

Closed devillemereuil closed 2 years ago

devillemereuil commented 2 years ago

Hi,

As far as I understand, lwgeom depends on SQLite only insofar as libproj depends on it (though maybe I'm wrong here, but it would only make my point more valid I guess?). Yet, as far as users and, more importantly perhaps, packagers are concerned, SQLite is a direct dependency of lwgeom, because it is needed to be installed on the system, including "-dev/-devel" subpackages in order to build lwgeom.

As such, I believe it would be relevant to add "SQLITE (>=3.XXX)" (I believe, correct version is 3.11, same as PROJ?) in the "SystemRequirements:" line of the DESCRIPTION file.

As a concrete example, on openSUSE, we are using an automatic build system for R packages to generate RPMs for our users, and it scans the DESCRIPTION file for this line in order to detect the needed system dependencies. Right now, it is failing for lwgeom because it lacks the (unspecified) SQLITE dependency at build time.

Thank you!

PS: Of note, I saw "sqlite3" is mentioned in "SystemRequirements" of the "sf" package.

edzer commented 2 years ago

PS: Of note, I saw "sqlite3" is mentioned in "SystemRequirements" of the "sf" package.

would that do, here, as well?

devillemereuil commented 2 years ago

I believe so, yes.