search

r-spatial / lwgeom

bindings to the liblwgeom library
https://r-spatial.github.io/lwgeom/
58 stars 23 forks source link

Adding LDFLAGS to all lines where test program is compiled in configure.ac #79

Closed cmarquardt closed 2 years ago

cmarquardt commented 2 years ago

This fixes #78 for me.

Note that the actual changes are in configure.ac; modifications to configure are due to my autoconf being newer than the one used for creating the original file.

Thanks for considering,

Christian.

cmarquardt commented 2 years ago

Uhh. In the Mac build (same as in the failing Mac tests for #77, by the way):

< Warning messages:
[163](https://github.com/r-spatial/lwgeom/runs/5725873346?check_suite_focus=true#step:9:163)
< 1: In fun(libname, pkgname) :
[164](https://github.com/r-spatial/lwgeom/runs/5725873346?check_suite_focus=true#step:9:164)
<   GEOS versions differ: lwgeom has 3.10.2 sf has 3.9.1
[165](https://github.com/r-spatial/lwgeom/runs/5725873346?check_suite_focus=true#step:9:165)
< 2: In fun(libname, pkgname) :
[166](https://github.com/r-spatial/lwgeom/runs/5725873346?check_suite_focus=true#step:9:166)
<   PROJ versions differ: lwgeom has 9.0.0 sf has 8.1.1

and 

proj_create: /Users/runner/work/_temp/Library/sf/proj/proj.db contains DATABASE.LAYOUT.VERSION.MINOR = 1 whereas a number >= 2 is expected. It comes from another PROJ installation.

What would cause that?

edzer commented 2 years ago

What would cause that?

sf was built in CI, cached, and after that PROJ has been updated. Nothing to do with your PR.

edzer commented 2 years ago

LGTM - thanks!