Use pkg-config on Windows when available.

r-spatial / lwgeom

bindings to the liblwgeom library

https://r-spatial.github.io/lwgeom/

58 stars 23 forks source link

Use pkg-config on Windows when available. #85

Closed kalibera closed 7 months ago

kalibera commented 11 months ago

This will use pkg-config to establish the libraries to link when pkg-config is available (which will soon be in Rtools). This should reduce the frequency of needed updates to linking when new features are linked/enabled in geos or proj or in libraries they use.

edzer commented 7 months ago

Thanks!

edzer commented 7 months ago

This now gives, on win-builder a WARNING, in 00install.log:

** applying installation-time patches
checking file src/Makevars.ucrt
Hunk #1 FAILED at 73.
1 out of 1 hunk FAILED
WARNING: failed to apply patch d:/RCompile/CRANpkg/r_packages/patches/CRAN/lwgeom.diff

shall I proceed submitting this to CRAN nevertheless?

kalibera commented 7 months ago

This now gives, on win-builder a WARNING, in 00install.log:
** applying installation-time patches
checking file src/Makevars.ucrt
Hunk #1 FAILED at 73.
1 out of 1 hunk FAILED
WARNING: failed to apply patch d:/RCompile/CRANpkg/r_packages/patches/CRAN/lwgeom.diff
shall I proceed submitting this to CRAN nevertheless?

I think you can submit. If it gets rejected, you can follow up on CRAN@r-project.org. Or you can ask there right away if you prefer.