Open elipousson opened 1 year ago
@tim-salabim – no rush, of course, but just wanted to make sure you'd seen that this pull request existed. I also wanted to offer that I can always modify the pull request changes if there was some but not all of these changes that you'd like to see added to the package.
Hi, sorry for the long silence. I'll get to this asap.
No apologies needed! Just let me know if you have any questions or suggestions.
hey are there any updates? thanks for fixing this
I started working on this only to address #124 but, I wanted the package to be able to clear devtools::check(), so I ended up addressing a variety of other small issues at the same time. Most of the changes are focused on avoiding whole library imports + moving the
@importFrom
tags to the function or package documentation. Key changes to imports include:I added cli and rlang to handle error and warning messages and use
rlang::check_installed()
for all the packages that are now in Suggests. I also switched the organization of the non-exported mapview functions to match the organization within the mapview repository.Lastly, I addressed #124 by replacing the calls to
dplyr::select_()
withdplyr::select()
anddplyr::all_of()
and incorporated the fix that @warnes used to address #127 in his pending pull request. Hope this is welcome pull request but I'm happy to make changes if needed!