search

r-spatial / mapedit

Interactive editing of spatial data in R
https://www.r-spatial.org/r/2019/03/31/mapedit_leafpm.html
Other
218 stars 33 forks source link

Easy way to allow users to contribute to the world's open geographical data commons #51

Open Robinlovelace opened 7 years ago

Robinlovelace commented 7 years ago

I'm thinking a way to allow users to edit and add OSM elements could be a massive boost for open data and ease contributions to R users.

I suspect @mpadge would be a fan of this idea and could provide an indication of whether the osmdata package could help.

May be a bit of a pipe-dream though as OSM data has a rather unusual data schema - even if it were only supported for points/tag changes it could be useful though. Food for thought...

mpadge commented 7 years ago

All theoretically do-able, but JOSM is so polished that it really would be a heap of largely redundant repetition just so people could do it in RStudio instead of JOSM. The data structures are not the issue; it's more that it would require at least roughly approximating the basic functionality of JOSM which'd be an enormous task. In particular, JOSM allows you to directly see entire changelogs which is something osmdata unfortunately can not do until some distant future when those are offered by overpass. Until that time, my opinion would be that it just won't be possible to create anything that good in R. (Notwithstanding the theoretical possibility of re-building osmdata to work directly with planet files which have change logs...)

tim-salabim commented 7 years ago

Nontheless, maybe a good idea to provide methods for class 'osmdata' (also for mapview). We'll keep this in mind

Robinlovelace commented 7 years ago

Thanks for the quickfire responses. @mpadge I agree with what you say about JOSM. Perhaps there could be a function (I'd suggest in osmdata) called something like osmdata_convert() or osmdata_check() or both that a) check if it can be represented in OSM. Then you could suggest people import it to JOSM and push it to the 'geographic data commons' that way...

I think those functions would be useful anyway, e.g. potentially allowing as(x, "osmdata") to work. Just realised that this thread may be in the wrong repo but it's as good as anywhere now I guess!

timelyportfolio commented 7 years ago

Love the idea, Please let us know if this is feasible and potentially helpful, and we will gladly try to implement.

mpadge commented 7 years ago

@Robinlovelace d'ya wanna open an issue in osmdata and explain a bit more what you have in mind? Ref this one and we can X-fertilise.