Open timelyportfolio opened 6 years ago
I should mention that I only got the suppressing of popups to work with leaflet 0.7.7, not 1.2 (current schloerke branch version). In the following, first line successfully prevents popups with 0.7.7 whereas second (commented out) line does not with 1.2.
var nodes = document.getElementByClass('popup-pane').getElementsByTagName('*');
//var nodes = document.getElementsByClassName('leaflet-popup-pane')[0].getElementsByTagName('*');
@tim-salabim, promoting https://github.com/timelyportfolio/mapedit/commit/d476b4cea4a4635914304c3fd1b3f1f01f7abcd7#commitcomment-27624345 here so we can fully integrate
crosstalk
. I'd like to leave crosstalk in experiments until after0.4.0
, so that this will not hold up CRAN submission.@timelyportfolio I have hacked a modification into this (see below) to enable selection only on ctrl + click using
if(e.originalEvent.ctrlKey){...}
. Hence, the map renders normally and popups can be queried as usual. When ctrl button is pressed then clicking will make the selection and popups are disabled. Would you mind having a look at this (I'm sure there's a smarter way of achieving this - my approach is copy&paste from SO). Also, what are your thoughts on having ctrl+click as the default behaviour for the click GUIs in mapedit (e.g. `selectFeatures(x, mode = "ctrlClick"))?