merged code for rstudio addin, updated DESCRIPTION imports and docs.

r-spatial / mapedit

Interactive editing of spatial data in R

https://www.r-spatial.org/r/2019/03/31/mapedit_leafpm.html

Other

218 stars 33 forks source link

merged code for rstudio addin, updated DESCRIPTION imports and docs. #85

Closed mrjoh3 closed 2 years ago

mrjoh3 commented 5 years ago

addin merge seems to work as expected. I have run devtools::check() without error. One possible issue is that the addin assigns to the .GlobalEnv which flags as a note in the checks. I will investigate a more elegant alternative.

timelyportfolio commented 5 years ago

@mrjoh3 I haven't forgotten and sorry for the delay. I still plan to get this in the next release. Thanks so much for the pull!!

mrjoh3 commented 5 years ago

That's fine @timelyportfolio there is no rush. Something to consider though, is that CRAN might not like the way the addin works as it is able to write to .GlobalEnv and to the file system. When you come to look at the PR please let me know if you need anything changed.

mrjoh3 commented 2 years ago

superseded by #122