search

r-spatial / mapedit

Interactive editing of spatial data in R
https://www.r-spatial.org/r/2019/03/31/mapedit_leafpm.html
Other
218 stars 33 forks source link

Allow editor options with editFeatures/drawFeatures #92

Open timelyportfolio opened 5 years ago

timelyportfolio commented 5 years ago

@tim-salabim brings up a good point in email and https://github.com/r-spatial/mapedit/issues/90#issuecomment-459247014 that currently there is no way to provide editor options in editFeatures or drawFeatures. This likely most affects editor = "leafpm" since a user might want to change snappable, snapDistance, and allowSelfIntersection. I'd like to target this for next release.

tim-salabim commented 5 years ago

Next release sounds good. Let's draw the RConsortium project to a close first

lbusett commented 5 years ago

I think being able to tweak also the "appearance" of the editFeatures map would be good, if possibile (e.g., stroke width and color, polygon transparency, shape/size of vertexes while editing....).

JoshOBrien commented 5 years ago

I just went ahead and modified editFeatures() to take and process additional arguments pmToolbarOpts, pmDrawOpts, pmEditOpts, and pmCutOpts, which it then passes on to the corresponding leafpm functions. Would this be welcome as a pull request, and if so, should I submit that and then link to this Issue in the pull request message?

tim-salabim commented 5 years ago

Yes, a PR would be great. You can simply put someting like " addresses #92" in your commit message to link the PR to this issue.