search

r-spatial / rgee

Google Earth Engine for R
https://r-spatial.github.io/rgee/
Other
668 stars 146 forks source link

Updated link in ee_utils_get_crs_web to use the GitHub URL for spatialreference.org data. #364

Closed MarShaikh closed 1 month ago

MarShaikh commented 2 months ago

This PR solves #363.

Summary

This PR addresses an issue with the ee_print function in the rgee package, which fails when attempting to retrieve metadata for some(?) image collections due to deprecated spatial reference URL. The error occurs when spatialreference.org is down, and the code attempts to fallback to the web archive, which is no longer supported. This PR modifies the ee_utils_get_crs_web function to use a GitHub backup for spatial reference data instead.

I did not write a test for this as there were no prior tests written for this function. However, I am happy to write a new test if necessary. Please feel free to correct any issues or let me to know which ones to address as well.

Thank you.

edanesh commented 1 month ago

Thank you! I had the same issue (for downloading MCD19A2 AOD MAIAC data) and updating the rgee package to your pull request solved my issue. For people like me who are less experienced with github installation of R packages, this is the code you need to use: remotes::install_github(repo="r-spatial/rgee", ref = remotes::github_pull(364))

ambarja commented 1 month ago

@MarShaikh excellent contribution, is it possible that you can test using the testhat package? I would like to merge this pull request.

MarShaikh commented 1 month ago

@ambarja Just added some tests! Please let me know of any changes :)

ambarja commented 1 month ago

@MarShaikh I’ll review it this week. Thank you very much for your contribution