search

r-spatial / sftime

time extension to sf objects
https://r-spatial.github.io/sftime/
Apache License 2.0
49 stars 5 forks source link

update on st_as_sftime.cubble_df #14

Closed huizezhang-sherry closed 1 year ago

huizezhang-sherry commented 1 year ago

replace old syntax after internal refactoring in cubble

edzer commented 1 year ago

This breaks CI for this repo because cubble 0.3-0 is not yet on CRAN. When do you plan to submit it?

huizezhang-sherry commented 1 year ago

This week.

huizezhang-sherry commented 1 year ago

Cubble 0.3.0 is now on CRAN :)

edzer commented 1 year ago

Thanks! stars used to call cubble::key_vars. What should it do now that is no longer available? https://github.com/r-spatial/stars/blob/main/R/cubble.R#L34

huizezhang-sherry commented 1 year ago

You can use head(names(attr(.x, "key")), -1). The generic of key_vars is in tsibble.